Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-3040) Fix grouping virtualization for DataGrid (ItemsControls) #3483

Merged
merged 3 commits into from
Apr 9, 2019
Merged

(GH-3040) Fix grouping virtualization for DataGrid (ItemsControls) #3483

merged 3 commits into from
Apr 9, 2019

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Apr 9, 2019

Describe the changes you have made to improve this project

Using IsVirtualizingWhenGrouping breaks virtualization for DataGrid and ItemsControls, so this PR fix this.

Additional context

The obsolete EnableVirtualizationWithGrouping attached property will also be deleted.

Closed Issues

Closes #3040

@punker76 punker76 added the Bug label Apr 9, 2019
@punker76 punker76 added this to the 2.0.0 milestone Apr 9, 2019
@punker76 punker76 merged commit 0eca771 into develop Apr 9, 2019
@punker76 punker76 deleted the feature/GH-3040-Virtualization branch April 9, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

DataGrid virtualization broken when grouping activated
1 participant
@punker76