Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [WIP] HamburgerMenu Scrolling #2892

Closed
wants to merge 6 commits into from
Closed

[RFC] [WIP] HamburgerMenu Scrolling #2892

wants to merge 6 commits into from

Conversation

amkuchta
Copy link
Contributor

What changed?

This PR updates the HamburgerMenu scroll behavior to match the UWP Toolkit (see UWP Toolkit Issue 954). The HamburgerMenu scrolling behavior now behaves as it should, however, using the scroll wheel on the mouse does not work... Any help on that would be awesome 😄 .

Closed issues.

#2857

@amkuchta amkuchta changed the title [WIP] HamburgerMenu Scrolling [RFC] [WIP] HamburgerMenu Scrolling Mar 16, 2017
@amkuchta
Copy link
Contributor Author

amkuchta commented Mar 16, 2017

Well, I didn't mean for the watermark items for get rolled into this, but I am not good enough with Git to know how to undo it, so I will leave it up to you guys (@punker, @Amrykid, all other super important people) how you want to proceed...

Changes

I love the functionality of the floating watermark, but don't like that the border stretches, as do any buttons contained within the control. My solution is to implement a watermark that floats outside of the control.

The latest two commits enhance the floating watermark by allowing users to decide whether or not they want it inside or outside of the control. Improvements include:

  • Creation of a DependencyProperty, FloatingWatermarkLocation, which can be used on the following controls:
    • TextBox
    • ComboBox
    • DatePicker
    • DateTimePicker
    • PasswordBox
    • NumericUpDown
  • Creation of an enum named FloatingWatermarkLocations to outline values acceptable for the newly created dependency property: Interior and Exterior
  • updates to the view to demonstrate the new feature (TextBox, DatePicker, DateTimePicker, ComboBox)

TODO (Help Needed)

Status on all controls:

  • TextBox - Fully implemented
  • PasswordBox - Fully implemented
  • DatePicker - Fully implemented
  • DateTimePicker - Fully implemented
  • ComboBox - Partially implemented: the new property works well on non-editable ComboBox controls... but if editing is enabled, forget about it (it works on initial load, but I cannot get it to work after the text has been changed). I could use some help wiring this together
  • NumericUpDown - No implementation: The Dependency Property can be used for the control, but for some reason, when I try to add the appropriate TemplateBinding line, I get errors thrown my way

@thoemmi , I figured that you may be the best person to take a look, since you did the initial creation of the UseFloatingWatermark feature. Thoughts?

@amkuchta
Copy link
Contributor Author

Closing to separate these two items how they should be (have to move HamburgerMenu off of my Develop branch to do so)

@amkuchta amkuchta closed this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant