-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the habilitiy to block the use of the scientific notation 'e'. #2423
Added the habilitiy to block the use of the scientific notation 'e'. #2423
Conversation
Added ContentStringFormat TemplateBinding to ToolTip
Revert "Added ContentStringFormat TemplateBinding to ToolTip"
…ecimals Fixes the HasDecimals property, broken before on commit bd6aa38.
…pDown-HasDecimals Revert "Fixes the HasDecimals property, broken before on commit bd6aa38."
…using the property HasScientificNotation. Updated the example as well.
^ @xxMUROxx @thoemmi ? |
I would rename the DP from HasScientificNotation to a name that is more saying what the property does. For my understanding the property should---if set to false---remove all I would suggest to change HasScientificNotation to AllowsScientificNotation
If we do not change the name of the DPs I would suggest to update the XML doc to indicate that setting this properties allows/dissalows the user to write specific chars But this is a suggestion. Keep free to comment. |
@@ -463,6 +469,18 @@ public bool HasDecimals | |||
set { SetValue(HasDecimalsProperty, value); } | |||
} | |||
|
|||
/// <summary> | |||
/// Indicates if the NumericUpDown should show the decimal separator or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment should be update to match the correct behavior.
In addition we could introduce a DP that can be set by an enum: NumericInputMode of type NumericInput
That would give us the benefit of adding additional behaviors if requested in the future. Then we should remove the other two existing DP (breaking change) |
…to Add-NumericUpDown-HasScientificNotation-Property
…o Add-NumericUpDown-HasScientificNotation-Property
…to Add-NumericUpDown-HasScientificNotation-Property
Any decisions on this? |
What changed?
Added the habilitiy to block the use of the scientific notation 'e', using the property HasScientificNotation. Updated the example as well.
closes #2422.