Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a tab doesn't work under specific circumstances #1639

Merged
merged 1 commit into from
Nov 9, 2014

Conversation

thoemmi
Copy link
Collaborator

@thoemmi thoemmi commented Nov 6, 2014

When MetroTabControl.ItemsSource is bound to a list of MetroTabItems, then closing a tab doesn't work. Currently the code requires that the bound items are not their own container.

When `MetroTabControl.ItemsSource` is bound to a list of `MetroTabItem`s, then closing a tab doesn't work. Currently the code requires that the bound items are not their own container.
@flagbug flagbug added this to the v1.0 milestone Nov 8, 2014
@flagbug flagbug self-assigned this Nov 8, 2014
flagbug added a commit that referenced this pull request Nov 9, 2014
Closing a tab doesn't work under specific circumstances
@flagbug flagbug merged commit 2df8f47 into MahApps:master Nov 9, 2014
@flagbug
Copy link
Member

flagbug commented Nov 9, 2014

Thanks @thoemmi !

@thoemmi thoemmi deleted the patch-1 branch November 9, 2014 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants