Match Flyout animation with Windows 8 #1460
Conversation
|
Any way to keep the opacity change as an option? I personally like the look of it (can't speak for everyone else) |
|
Then a property will have to be added to Flyout.cs. I'll add it within a few hours or so, maybe tomorrow. |
NOTE: Any code formatting changes Visual Studio did are also 'seen' by Git.
NOTE: code formatting changes that Visual Studio made are also 'seen' by Git.
|
Ok, the property AnimateOpacity is added to the Flyout class. The first flyout in the Flyout demo has an animated opacity when showing/closing. |
|
Awesome, thanks! |
| /// <summary> | ||
| /// Gets/sets the mouse button that closes the flyout on an external mouse click. | ||
| /// </summary> | ||
| public MouseButton ExternalCloseButton | ||
| { | ||
| get { return (MouseButton) GetValue(ExternalCloseButtonProperty); } |
There was a problem hiding this comment.
Please don't change any code stylings in this PR
|
I never wanted to do any code stylings, but Visual Studio does that for me. I could also just copy/paste the lines of code changed into the GitHub web editor and edit it that way. Then I will have to revert the changes I made earlier, and edit the new lines into them, right? If so, how? I'm a beginner at Git... |
|
Merged this manually without the code style changes. ✨ |
I noticed when I started using Flyouts that the easing function did not match the Windows 8 animation. I tried to change it using KeySpline, but I couldn't find the correct control points. Then I realized I also had Blend installed with VS, and I was pretty sure it had a GUI function to create a keyspline.
I experimented in Blend with key splines and found that a KeySpline with the points (0.25, 1) and (0.05, 1) matches the Windows 8 Flyout animation the most. So I changed the Easing functions in the Flyout theme XAML to those KeySplines.
I also removed the opacity change in the Flyouts, since I never saw an opacity change occur in the Windows 8 Flyouts.