Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in v2.0: Effect of parent's IsEnabled on DropDownButton #3811

Closed
yjagota opened this issue May 26, 2020 · 1 comment · Fixed by #3819
Closed

Regression in v2.0: Effect of parent's IsEnabled on DropDownButton #3811

yjagota opened this issue May 26, 2020 · 1 comment · Fixed by #3819
Labels
Bug
Milestone
2.0.1

Comments

@yjagota
Copy link

yjagota commented May 26, 2020

Description of the bug
If a parent containing a DropDownButton has a bound IsEnabled property, and the property is switched to disabled and enabled again, the DropDownButton remains disabled. This only happens in v2.0.0 but works as expected in v1.6.5.

Expected behavior
The DropDownButton should be enabled again when parent's IsEnabled is set to true.

Environment:

  • MahApps.Metro version v2.0.0
  • Win10 1909
  • Visual Studio 2019 16.6.0
  • .NET Framework 4.7.2

Repo
https://github.com/yjagota/MahAppsTest
@punker76 punker76 added the Bug label May 26, 2020
yjagota added a commit to yjagota/MahApps.Metro that referenced this issue May 26, 2020
@yjagota
Fixed MahApps#3811: Effect of parent's IsEnabled on DropDownButton
189fe10
@yjagota yjagota mentioned this issue May 26, 2020
Closed
@punker76 punker76 added this to the 2.x.x milestone May 26, 2020
yjagota added a commit to yjagota/MahApps.Metro that referenced this issue May 26, 2020
@yjagota
Fixed MahApps#3811: Effect of parent's IsEnabled on DropDownButton
9d057bd
@yjagota yjagota mentioned this issue May 26, 2020
Closed
punker76 added a commit that referenced this issue May 26, 2020
@punker76
(GH-3811) Fix parent IsEnabled behavior for DropDownButton
3d9c24a 
The DropDownButton doesn't toggle to enabled again if the parent control toggles their IsEnabled property.
punker76 added a commit that referenced this issue May 26, 2020
@punker76
(GH-3811) Fix parent IsEnabled behavior for SplitButton
8222ebb 
The SplitButton doesn't toggle to enabled again if the parent control toggles their IsEnabled property.
@punker76 punker76 mentioned this issue May 26, 2020
Merged
punker76 added a commit that referenced this issue May 26, 2020
@punker76
(GH-3811) Add unit tests
c0d738c 
- DropDownButtonShouldRespectParentIsEnabledProperty
- SplitButtonShouldRespectParentIsEnabledProperty
punker76 added a commit that referenced this issue May 26, 2020
@punker76
Merge pull request #3819 from MahApps/fix/GH-3811-DropDownButton-IsEn…
c72febe 
…abled-Fix

Fix parent IsEnabled behavior for DropDownButton and SplitButton
@punker76
Copy link
Member

@yjagota Thanks for reporting this issue! It's now fixed with #3819 and will be available with next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Milestone
2.0.1
Development

Successfully merging a pull request may close this issue.

Fix parent IsEnabled behavior for DropDownButton and SplitButton MahApps/MahApps.Metro
2 participants
@yjagota @punker76