Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old ToggleSwitch and replace with UWP like ToggleSwitch #3753

Closed
punker76 opened this issue Feb 26, 2020 · 3 comments · Fixed by #3756
Closed

Remove old ToggleSwitch and replace with UWP like ToggleSwitch #3753

punker76 opened this issue Feb 26, 2020 · 3 comments · Fixed by #3756
Assignees
Milestone

Comments

@punker76
Copy link
Member

punker76 commented Feb 26, 2020

Remove old ToggleSwitch and ToggleSwitchButton class and create UWP like ToggleSwitch.

image

Closes #3276
Closes #3527
Closes #3690
Closes #2762

@punker76 punker76 added this to the 2.0.0 milestone Feb 26, 2020
@punker76 punker76 self-assigned this Feb 26, 2020
@timunie
Copy link
Collaborator

timunie commented Feb 27, 2020

Hi @punker76 ,
is it possible to implement an indeterminate state to this control, so we can bind to bool?. see #3527

Thank you and happy coding,
Tim

@punker76
Copy link
Member Author

punker76 commented Feb 27, 2020

@timunie No, I will not implement this here for this ToggleSwitch. IMO a ToggleSwitch should not have this behavior. If you need this, then this is the wrong control.

@timunie
Copy link
Collaborator

timunie commented Feb 27, 2020

Hi Jan,
thank you for the feedback. I get your point, but in my special use case I have to let the user do a choice. So I will maybe stick with a custom control which does what I need, or switch to another control if I find one.

punker76 added a commit that referenced this issue Feb 28, 2020
punker76 added a commit that referenced this issue Mar 1, 2020
punker76 added a commit that referenced this issue Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants