Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox borders do not match other control borders (and other enhancement ideas) #1527

Closed
amkuchta opened this issue Aug 25, 2014 · 3 comments
Milestone

Comments

@amkuchta
Copy link
Contributor

So this one is small, but I think it should be addressed to bring cohesion to all of the controls. The border surrounding the checkbox is darker than that of other controls, as demonstrated below:

mam_borderdifferences

I think that the border should be lightened to match the other controls, with it darkening on MouseOver. I also think that there should be an option to utilize TextboxHelper.MouseOverBorderBrush to change the CheckBox outline color / font color on MouseOver (this might also tie into #1520 as well).

Any thoughts?

@flagbug flagbug added this to the v1.0 milestone Sep 15, 2014
@amkuchta
Copy link
Contributor Author

@flagbug @100GPing100 #1589 doesn't correct this... I am still showing that the border values do not match (Checkbox is still dark, Textbox and other controls are still light). Additionally, the MouseOverBorderBrush does not change the color of the actual checkbox itself (the checkbox border is still its default value on MouseOver; I really believe that this should probably be implemented in a separate CheckboxHelper).

Requesting that this be re-opened.

@flagbug
Copy link
Member

flagbug commented Oct 27, 2014

Huh? This issue isn't closed an there hasn't been an attempt made to fix this yet.

@amkuchta
Copy link
Contributor Author

Whoops... I read the #1589 being closed. Ha. My bad!

flagbug added a commit that referenced this issue Oct 29, 2014
This PR moved the FocusBorderBrush and MouseOverBorderBrush attached properties back to the ControlsHelper class and enables them to also be set for the Checkbox and RadioButton class

Fixes #1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants