reshape hack so that ESPIRIT is compatible with the MKL backend of FFTW #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 66.68% // Head: 66.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 37 37
Lines 1696 1696
=======================================
Hits 1131 1131
Misses 565 565
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Oh this is ugly but I am pragmatic here. The code still makes sense and it basically says: Ignore all dimensions before the spatial ones. So fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
it seems that FFTW with the MKL backend does not support calls like
fft!(x, 3:ndims(x)):JuliaMath/FFTW.jl#252
I implemented a hack to circumvent this problem by doing a reshape and then calling
fft!(x, 2:ndims(x)-1). If found virtually no speed regression when using the FFTW backend and, well, no error when using the MKL backend ;). (I tested it speed wise with the small example in the test and replace@timewith@btimefor reliable benchmarking.