Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved generalization of Positions to n-D #39

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

jusack
Copy link
Contributor

@jusack jusack commented Jun 7, 2021

MeanderingGridPositions was not correctly defined for a 2D grid, since the implementation was assuming the grid to be 3D. I updated the code to generalize to N-D. Also it was not possible to create a RegularGrid with more than three dimensions, which is probably not relevant anyways but at least now you are able to.

@jusack jusack requested a review from tknopp June 7, 2021 16:10
@tknopp
Copy link
Member

tknopp commented Jun 7, 2021

LGTM. Thanks

@tknopp tknopp merged commit e976bfd into master Jun 7, 2021
@jonschumacher jonschumacher deleted the JA/positions branch September 15, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants