Skip to content

Commit

Permalink
Merge pull request #63 from rsdefever/bugfix/line_items
Browse files Browse the repository at this point in the history
Expand maximum line length and number of items per line
  • Loading branch information
Eliseo Marin-Rimoldi committed Jun 25, 2020
2 parents c32e5cb + 622e61e commit 0255ae0
Show file tree
Hide file tree
Showing 9 changed files with 50 additions and 47 deletions.
2 changes: 1 addition & 1 deletion Src/create_nonbond_table.f90
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ SUBROUTINE Create_Nonbond_Table
!custom mixing rules
INTEGER :: ierr,line_nbr,nbr_entries, is_1, is_2, ia_1, ia_2, itype_custom, jtype_custom
INTEGER :: i_type1, i_type2
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)


!******************************************************************************
Expand Down
2 changes: 1 addition & 1 deletion Src/gcmc_control.f90
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ SUBROUTINE GCMC_Control
IMPLICIT NONE

INTEGER :: ierr,line_nbr,nbr_entries, i,j, ii,this_mol
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
REAL(DP) :: e_total_bond, e_total_angle, e_total_intra_nb, e_total_inter_nb
REAL(DP) :: E_bond, E_angle, E_dihedral, E_improper
REAL(DP) :: E_intra_vdw, E_intra_qq, E_inter_vdw, E_inter_qq, W_intra_vdw, W_intra_qq
Expand Down
64 changes: 32 additions & 32 deletions Src/input_routines.f90
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ SUBROUTINE Get_Run_Name
!******************************************************************************

INTEGER :: ierr,line_nbr,nbr_entries
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)


!******************************************************************************
Expand Down Expand Up @@ -123,7 +123,7 @@ SUBROUTINE Get_Nspecies
!******************************************************************************

INTEGER :: ierr,line_nbr,nbr_entries, i
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
!******************************************************************************
WRITE(logunit,*)
WRITE(logunit,'(A)') 'Number of species'
Expand Down Expand Up @@ -255,7 +255,7 @@ SUBROUTINE Get_Sim_Type
! ignored.
!******************************************************************************
INTEGER :: ierr,line_nbr,nbr_entries
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -356,7 +356,7 @@ SUBROUTINE Get_Pair_Style
! need to be stored.
!******************************************************************************
INTEGER :: ierr,line_nbr,nbr_entries, iassign, ibox, k
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

REAL(DP), ALLOCATABLE :: ewald_tol(:)

Expand Down Expand Up @@ -879,7 +879,7 @@ SUBROUTINE Get_Mixing_Rules
! ignored. If no mixing rule is specified, Lorentz-Berthelot is used as default.
!******************************************************************************
INTEGER :: ierr,line_nbr,nbr_entries
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
REWIND(inputunit)
Expand Down Expand Up @@ -952,7 +952,7 @@ SUBROUTINE Get_Molecule_Info

INTEGER :: ierr,line_nbr,nbr_entries, i, openstatus, is, max_index, input_line_nbr
INTEGER :: mcf_index(5), dummy
CHARACTER(120) :: line_string, line_array(20), source_dir
CHARACTER(STRING_LEN) :: line_string, line_array(60), source_dir
LOGICAL :: l_source_dir

!******************************************************************************
Expand Down Expand Up @@ -1360,7 +1360,7 @@ SUBROUTINE Get_Atom_Info(is)
INTEGER, INTENT(IN) :: is

INTEGER :: ierr,line_nbr,nbr_entries, ia
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
REWIND(molfile_unit)
Expand Down Expand Up @@ -1620,7 +1620,7 @@ SUBROUTINE Get_Bond_Info(is)
INTEGER, INTENT(IN) :: is

INTEGER :: ierr,line_nbr,nbr_entries, ib
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
REWIND(molfile_unit)
Expand Down Expand Up @@ -1765,7 +1765,7 @@ SUBROUTINE Get_Angle_Info(is)
INTEGER, INTENT(IN) :: is

INTEGER :: ierr,line_nbr,nbr_entries, iang, nangles_linear
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
REWIND(molfile_unit)
Expand Down Expand Up @@ -1940,7 +1940,7 @@ SUBROUTINE Get_Dihedral_Info(is)
INTEGER, INTENT(IN) :: is

INTEGER :: ierr,line_nbr,nbr_entries, idihed
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
REWIND(molfile_unit)
Expand Down Expand Up @@ -2170,7 +2170,7 @@ SUBROUTINE Get_Improper_Info(is)
INTEGER, INTENT(IN) :: is

INTEGER :: ierr,line_nbr,nbr_entries, iimprop
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
REWIND(molfile_unit)
Expand Down Expand Up @@ -2334,7 +2334,7 @@ SUBROUTINE Get_Fragment_Anchor_Info(is)

INTEGER :: i, line_nbr, ierr, min_entries, nbr_entries, ianchor

CHARACTER(120) :: line_String,line_array(20)
CHARACTER(STRING_LEN) :: line_String,line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -2441,7 +2441,7 @@ SUBROUTINE Get_Fragment_Info(is)
INTEGER :: nanchors, iatoms, jatoms, ibonds, iatoms_bond
INTEGER :: i_atom, j_atom, atom1, atom2
INTEGER, ALLOCATABLE :: anchor_id(:)
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
!CHARACTER(50000) :: line_array_zeo(10000)

!******************************************************************************
Expand Down Expand Up @@ -2676,7 +2676,7 @@ SUBROUTINE Get_Fragment_Connectivity_Info(is)
INTEGER :: ierr, line_nbr, ifrag, nbr_entries, i, j, ifrag_connect, frag1, frag2
INTEGER, ALLOCATABLE :: temp_frag(:)

CHARACTER(120) :: line_string,line_array(20)
CHARACTER(STRING_LEN) :: line_string,line_array(60)

! Variables for determing prob_del1
INTEGER :: natoms_del_with_frag1, natoms_del_with_frag2
Expand Down Expand Up @@ -2943,7 +2943,7 @@ SUBROUTINE Get_Fragment_File_Info(is)

INTEGER :: ierr, line_nbr, i, j, ifrag, nbr_entries, is
REAL(DP) :: vdw_cutoff, coul_cutoff
CHARACTER(120) :: line_string, line_array(20), source_dir
CHARACTER(STRING_LEN) :: line_string, line_array(60), source_dir
CHARACTER(4) :: ring_flag
LOGICAL :: l_source_dir

Expand Down Expand Up @@ -3302,7 +3302,7 @@ END SUBROUTINE Get_Fragment_Coords
SUBROUTINE Get_Intra_Scaling(is)
!******************************************************************************
INTEGER :: ierr,line_nbr,nbr_entries, iimprop, is, i
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
LOGICAL :: l_intra_scaling_mcf

!******************************************************************************
Expand Down Expand Up @@ -3493,7 +3493,7 @@ SUBROUTINE Get_Box_Info
! cubic, orthogonal, cell_metrix
!******************************************************************************
INTEGER :: ierr,line_nbr,nbr_entries,ibox, is
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
REAL(DP) :: radius, zmax, zmin

!******************************************************************************
Expand Down Expand Up @@ -3829,7 +3829,7 @@ SUBROUTINE Get_Temperature_Info
IMPLICIT NONE

INTEGER :: ierr, line_nbr, i, nbr_entries
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -3910,7 +3910,7 @@ SUBROUTINE Get_Pressure_Info
!******************************************************************************

INTEGER :: ierr, line_nbr, nbr_entries, i
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -3990,7 +3990,7 @@ SUBROUTINE Get_Chemical_Potential_Info
IMPLICIT NONE

INTEGER :: line_nbr, nbr_entries, ierr, is, spec_counter, ibox
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
REWIND(inputunit)
Expand Down Expand Up @@ -4095,7 +4095,7 @@ SUBROUTINE Get_Move_Probabilities

INTEGER :: ierr, nbr_entries, line_nbr, i, j, ibox, is, vol_int
INTEGER :: kbox, this_box, first_species, second_species
CHARACTER(120) :: line_string, line_array(30), line_string2
CHARACTER(STRING_LEN) :: line_string, line_array(60), line_string2
CHARACTER(4) :: Symbol
!INTEGER, DIMENSION(:,:), ALLOCATABLE :: swap_list

Expand Down Expand Up @@ -4776,7 +4776,7 @@ SUBROUTINE Get_Start_Type
!******************************************************************************

INTEGER :: ierr, line_nbr, nbr_entries, i,j, ibox, is
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
CHARACTER(1) :: first_character
CHARACTER(4) :: symbol

Expand Down Expand Up @@ -5059,7 +5059,7 @@ SUBROUTINE Get_Run_Type
IMPLICIT NONE

INTEGER :: ierr, line_nbr, nbr_entries,i, ia
CHARACTER(120) :: line_string,line_array(20)
CHARACTER(STRING_LEN) :: line_string,line_array(60)
LOGICAL :: overlap

!******************************************************************************
Expand Down Expand Up @@ -5185,7 +5185,7 @@ SUBROUTINE Get_CBMC_Info

INTEGER :: ibox, is
INTEGER :: ierr, line_nbr, nbr_entries
CHARACTER(120) :: line_string,line_array(30)
CHARACTER(STRING_LEN) :: line_string,line_array(60)
LOGICAL :: need_kappa_ins, need_kappa_dih

!******************************************************************************
Expand Down Expand Up @@ -5345,7 +5345,7 @@ SUBROUTINE Get_Seed_Info
!******************************************************************************

INTEGER :: ierr, line_nbr, nbr_entries
CHARACTER(120) :: line_string,line_array(20)
CHARACTER(STRING_LEN) :: line_string,line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -5410,7 +5410,7 @@ SUBROUTINE Get_Simulation_Length_Info
!******************************************************************************

INTEGER :: ierr, line_nbr, nbr_entries, ibox
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
LOGICAL :: l_run

!******************************************************************************
Expand Down Expand Up @@ -5701,7 +5701,7 @@ SUBROUTINE Get_Property_Info

INTEGER :: ierr, line_nbr, nbr_properties, max_properties, nbr_entries
INTEGER :: i, j, this_box, ibox, is, average_id, ifrac
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
CHARACTER(12) :: extension
CHARACTER(9) :: extension1
CHARACTER(17) :: extension2
Expand Down Expand Up @@ -6084,7 +6084,7 @@ SUBROUTINE Copy_Inputfile
!******************************************************************************

INTEGER :: ierr, line_nbr, line_inputfile_start
CHARACTER(120) :: line_string
CHARACTER(STRING_LEN) :: line_string
LOGICAL :: input_startcopy

WRITE(logunit,*)
Expand Down Expand Up @@ -6170,7 +6170,7 @@ SUBROUTINE Get_Rcutoff_Low
!******************************************************************************

INTEGER :: ierr, line_nbr, nbr_entries
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -6231,7 +6231,7 @@ SUBROUTINE Get_File_Info

INTEGER :: ierr, nbr_entries, line_nbr, is

CHARACTER(120) :: line_array(20), line_string
CHARACTER(STRING_LEN) :: line_array(60), line_string

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -6296,7 +6296,7 @@ SUBROUTINE Get_Lattice_File_Info
IMPLICIT NONE

INTEGER :: line_nbr, ierr, nbr_entries
CHARACTER*120 :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down Expand Up @@ -6457,7 +6457,7 @@ SUBROUTINE Get_Verbosity_Info
!******************************************************************************

INTEGER :: ierr,line_nbr,nbr_entries
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)

!******************************************************************************
WRITE(logunit,*)
Expand Down
17 changes: 10 additions & 7 deletions Src/io_utilities.f90
Original file line number Diff line number Diff line change
Expand Up @@ -54,24 +54,27 @@ MODULE IO_Utilities
! 12/10/13 : Beta version
!********************************************************************************
USE Global_Variables
USE File_Names

IMPLICIT NONE

INTEGER, PARAMETER :: STRING_LEN = 360

CONTAINS

!********************************************************************************
SUBROUTINE Read_String(file_number,string,ierr)
!********************************************************************************
! This routine just reads a single string from a file with unit number
! equal to file_number and returns that 120 character string. It returns
! equal to file_number and returns that 360 character string. It returns
! ierr .ne. 0 if it couldn't read the file.
!********************************************************************************
INTEGER, INTENT(IN) :: file_number
INTEGER, INTENT(OUT) :: ierr
CHARACTER(120), INTENT(OUT) :: string
CHARACTER(STRING_LEN), INTENT(OUT) :: string
!********************************************************************************

READ(file_number,'(A120)',IOSTAT=ierr) string
READ(file_number,'(A360)',IOSTAT=ierr) string
IF (ierr .NE. 0) RETURN

END SUBROUTINE Read_String
Expand All @@ -86,12 +89,12 @@ SUBROUTINE Parse_String(file_number,line_nbr,min_entries,nbr_entries,line_array,
! different by detecting a space between entries. It also tests to see if the
! minimum number of entries specified was met or not. If not, and error is returned.
!********************************************************************************
CHARACTER(120), INTENT(OUT) :: line_array(20)
CHARACTER(STRING_LEN), INTENT(OUT) :: line_array(60)
INTEGER, INTENT(IN) :: file_number,min_entries,line_nbr
INTEGER, INTENT(OUT) :: nbr_entries
INTEGER, INTENT(INOUT) :: ierr

CHARACTER(120) :: string
CHARACTER(STRING_LEN) :: string
INTEGER :: line_position,i
LOGICAL :: space_start
!********************************************************************************
Expand All @@ -107,7 +110,7 @@ SUBROUTINE Parse_String(file_number,line_nbr,min_entries,nbr_entries,line_array,

! Read the string from the file
CALL Read_String(file_number,string,ierr)

IF (string(1:1) .NE. '!') THEN
IF (string(1:1) .NE. ' ') THEN
! first character is an entry, so advance counter
Expand Down Expand Up @@ -244,7 +247,7 @@ SUBROUTINE Name_Files(prefix,suffix,new_name)
IMPLICIT NONE

INTEGER :: prefix_length
CHARACTER(120) :: prefix,new_name
CHARACTER(FILENAME_LEN) :: prefix, new_name
CHARACTER(*) :: suffix

prefix_length = LEN_TRIM(prefix)
Expand Down
2 changes: 1 addition & 1 deletion Src/make_config.f90
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ SUBROUTINE Make_Config(ibox)

LOGICAL :: overlap, cbmc_overlap

CHARACTER*120 :: init_config_file, init_config_file1
CHARACTER(FILENAME_LEN) :: init_config_file, init_config_file1
!*******************************************************************************
! Place molecules in the box using CB growth.

Expand Down
2 changes: 1 addition & 1 deletion Src/mcf_control.f90
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ SUBROUTINE MCF_Control
IMPLICIT NONE

INTEGER :: ierr,line_nbr,nbr_entries, i,j, ii,this_mol
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
REAL(DP) :: e_total_bond, e_total_angle, e_total_intra_nb, e_total_inter_nb
REAL(DP) :: E_bond, E_angle, E_dihedral, E_improper
REAL(DP) :: E_intra_vdw, E_intra_qq, E_inter_vdw, E_inter_qq, W_intra_vdw, W_intra_qq
Expand Down
2 changes: 1 addition & 1 deletion Src/nptmc_control.f90
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ SUBROUTINE NPTMC_Control
IMPLICIT NONE

INTEGER :: ierr,line_nbr,nbr_entries, i,j, ii,this_mol
CHARACTER(120) :: line_string, line_array(20)
CHARACTER(STRING_LEN) :: line_string, line_array(60)
REAL(DP) :: e_total_bond, e_total_angle, e_total_intra_nb, e_total_inter_nb
REAL(DP) :: E_bond, E_angle, E_dihedral, E_improper
REAL(DP) :: E_intra_vdw, E_intra_qq, E_inter_vdw, E_inter_qq, W_intra_vdw, W_intra_qq
Expand Down
Loading

0 comments on commit 0255ae0

Please sign in to comment.