Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neuron): add ckb node size alert #74

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

PainterPuppets
Copy link
Contributor

Add node size alert when downloading neuron

resolve: Magickbase/neuron-public-issues#255

image image

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 2:40am
magickbase-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 2:40am
neuron-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 2:40am
status-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 2:40am

@Danie0918
Copy link
Collaborator

Danie0918 commented Apr 3, 2024

  1. 点击继续并开始下载后,需要关闭弹窗,目前没有关闭弹窗

image

  1. 移动端样式需要优化,

(1)下载须知框建议与上下预留等间距

image

(2)弹窗目前占比过大

image

packages/neuron/public/locales/zh/download.json Outdated Show resolved Hide resolved
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Signed-off-by: 布偶什么的就是布偶 <painterpuppets@gmail.com>
@Keith-CY
Copy link
Member

Keith-CY commented Apr 3, 2024

@Danie0918 please have a review

@PainterPuppets PainterPuppets merged commit 11e4017 into master Apr 3, 2024
5 checks passed
@PainterPuppets PainterPuppets deleted the add_node_size_alert branch April 3, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show estimation of synchronization metrics on Neuron's page
3 participants