Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix account api return account or address (Issue 1235) #1241

Merged
merged 7 commits into from
Jan 4, 2023

Conversation

Naupio
Copy link
Contributor

@Naupio Naupio commented Dec 28, 2022

What problem does this PR solve?

fix account api return account or address (union type)

warning: this pr will break change account api result to union type 'account_or_address'
link issue: #1235

@FrederLu @Keith-CY
example

    query {
      account(input: {address: "0x59b670e9fa9d0a427751af201d676719a970857b"}){
        ... on Account{
          type
          eth_address
        }
      }
    }
    query {
      account(input: {address: "0x59b670e9fa9d0a427751af201d676719a970857e"}){
        ... on Address{
          eth_address
        }
      }
    }

example

Check List

Test

  • unit test

Task

  • none

@coveralls
Copy link
Collaborator

coveralls commented Dec 28, 2022

Pull Request Test Coverage Report for Build 04bdf574366fd92d724833bc6c245d1da8564c4b-PR-1241

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 38.713%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/godwoken_explorer/graphql/types/account.ex 3 4 75.0%
Totals Coverage Status
Change from base Build 9d512363b73f3bb395dd89a0aec2622812cd991e: 0.04%
Covered Lines: 2442
Relevant Lines: 6308

💛 - Coveralls

@Keith-CY
Copy link
Member

Hold on until front-end has been updated for the compatibility

@alexsupa597
Copy link

alexsupa597 commented Jan 3, 2023

PR for updating Basic Info: Magickbase/godwoken-explorer-ui#828

@alexsupa597
Copy link

alexsupa597 commented Jan 4, 2023

PR for updating display when we got a data of Address in account detail page. Magickbase/godwoken-explorer-ui#834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants