Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user account add zero address link jump #936

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

alexsupa597
Copy link
Contributor

@alexsupa597 alexsupa597 commented Apr 25, 2023

What problem does this PR solve?

As title.

GwScan._.User.Account.0x7752dcd7c6ce4aed048c028021d635cbec6c001d.-.26.April.2023.mp4

Ref: Magickbase/godwoken_explorer#1417

Check List

Test

e2e Test

Task

none

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
godwoken-explorer-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 0:52am

@codecov-commenter
Copy link

Codecov Report

Merging #936 (0c7f078) into develop (2932ed5) will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #936      +/-   ##
===========================================
- Coverage    67.62%   67.07%   -0.56%     
===========================================
  Files           18       18              
  Lines         1325     1321       -4     
  Branches       788      788              
===========================================
- Hits           896      886      -10     
- Misses         374      380       +6     
  Partials        55       55              

see 3 files with indirect coverage changes

@alexsupa597 alexsupa597 changed the title Fix: User account add zero address link jump fix: User account add zero address link jump Apr 26, 2023
@alexsupa597 alexsupa597 changed the title fix: User account add zero address link jump fix: user account add zero address link jump Apr 26, 2023
@alexsupa597 alexsupa597 force-pushed the fix/user-account-add-zero-address-link-jump branch 2 times, most recently from 7cfb951 to 5ac838a Compare April 26, 2023 09:43
@alexsupa597 alexsupa597 force-pushed the fix/user-account-add-zero-address-link-jump branch 2 times, most recently from 468d9e5 to 6f0c1dd Compare April 26, 2023 12:48
@alexsupa597 alexsupa597 force-pushed the fix/user-account-add-zero-address-link-jump branch from 6f0c1dd to 020f988 Compare April 26, 2023 12:49
@Keith-CY Keith-CY merged commit 291b2d8 into develop Apr 27, 2023
@Keith-CY Keith-CY deleted the fix/user-account-add-zero-address-link-jump branch April 27, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants