fix:page display account is undefined #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Keith-CY
reviewed
Mar 28, 2023
package.json
Outdated
| @@ -56,7 +56,7 @@ | |||
| "@types/node": "18.11.19", | |||
| "@types/phoenix": "1.5.4", | |||
| "@types/qrcode": "1.5.0", | |||
| "@types/react": "17.0.53", | |||
| "@types/react": "^18.0.4", | |||
There was a problem hiding this comment.
Dep should be pinned. And are there no changes in yarn.lock when the dep is upgraded?
There was a problem hiding this comment.
https://github.com/Magickbase/godwoken-explorer-ui/actions/runs/4540819243/jobs/8002232845?pr=928#step:4:23 CI failed because of the inconsistency
There was a problem hiding this comment.
Dep should be pinned. And are there no changes in
yarn.lockwhen the dep is upgraded?
yep. The version of Dep was fixed and the error was also resolved.
The yarn.lock seems to be ignored and the package-lock is instead.
alexsupa597
force-pushed
the
fix/page-display-account-is-undefined
branch
from
302ed1e to
dd8e3e0
Compare
alexsupa597
force-pushed
the
fix/page-display-account-is-undefined
branch
from
dd8e3e0 to
f5be983
Compare
Codecov Report
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
- Coverage 68.30% 67.07% -1.24%
===========================================
Files 18 18
Lines 1325 1321 -4
Branches 788 788
===========================================
- Hits 905 886 -19
- Misses 364 380 +16
+ Partials 56 55 -1
|
Keith-CY
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As title.
Ref: Magickbase/godwoken_explorer#1351
Check List
Test
e2e Test
Task
none