-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: change the pagination to cursor and add sorter --- NFT collections #737
Feat: change the pagination to cursor and add sorter --- NFT collections #737
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Naupio Please also pay attention to my comment under this issue. Cause we still missing a sorter in the API of this page. If I make a mistake. Please let me know. Thanks a lot. |
@Naupio Please post your PR links, if you finish the update. So, I can track it. Thanks a lot. |
@Naupio I wondered whether it is expected when I sorted the |
e97cfa5
to
c2d5688
Compare
c2d5688
to
46fc017
Compare
Codecov Report
@@ Coverage Diff @@
## develop #737 +/- ##
===========================================
+ Coverage 66.77% 67.22% +0.45%
===========================================
Files 18 18
Lines 1288 1321 +33
Branches 771 788 +17
===========================================
+ Hits 860 888 +28
- Misses 373 378 +5
Partials 55 55
|
d31f07a
to
b73b457
Compare
b73b457
to
135c993
Compare
7673f5c
to
7d487e9
Compare
7d487e9
to
e33e1bb
Compare
What problem does this PR solve?
This PR is for the page of
NFT-collections
.Ref: Magickbase/godwoken_explorer#556
Check List
1、sorted by total supply/circulating supply
2、sorted by holders
3、sorted by name
4、filtered by name (fuzzy)
Test
e2e Test
Task
none