Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: change the pagination to cursor and add sorter --- NFT collections #737

Merged
merged 11 commits into from
Mar 23, 2023

Conversation

alexsupa597
Copy link
Contributor

What problem does this PR solve?

This PR is for the page of NFT-collections.

Ref: Magickbase/godwoken_explorer#556

Check List

1、sorted by total supply/circulating supply
2、sorted by holders
3、sorted by name
4、filtered by name (fuzzy)

Test

e2e Test

Task

none

@auto-add-label auto-add-label bot added the Feat label Nov 21, 2022
@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
godwoken-explorer-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 4:52AM (UTC)

@alexsupa597
Copy link
Contributor Author

@Naupio Please also pay attention to my comment under this issue. Cause we still missing a sorter in the API of this page. If I make a mistake. Please let me know. Thanks a lot.

image

@alexsupa597
Copy link
Contributor Author

alexsupa597 commented Jan 17, 2023

@Naupio Please post your PR links, if you finish the update. So, I can track it. Thanks a lot.

@alexsupa597
Copy link
Contributor Author

imag@Naupio

@Naupio I wondered whether it is expected when I sorted the minted_count in ASC.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #737 (e33e1bb) into develop (c31cc49) will increase coverage by 0.45%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #737      +/-   ##
===========================================
+ Coverage    66.77%   67.22%   +0.45%     
===========================================
  Files           18       18              
  Lines         1288     1321      +33     
  Branches       771      788      +17     
===========================================
+ Hits           860      888      +28     
- Misses         373      378       +5     
  Partials        55       55              
Impacted Files Coverage Δ
pages/nft-collections/index.tsx 81.69% <85.71%> (+2.74%) ⬆️

@alexsupa597 alexsupa597 force-pushed the feat/data-sorting-filtering-nft-collections branch from 7673f5c to 7d487e9 Compare March 7, 2023 16:42
@FrederLu
Copy link
Contributor

@JeffreyMa597
The E2E test shows that there is a problem, you need to look at it.
image

@alexsupa597 alexsupa597 force-pushed the feat/data-sorting-filtering-nft-collections branch from 7d487e9 to e33e1bb Compare March 23, 2023 04:47
@alexsupa597 alexsupa597 merged commit 703b622 into develop Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants