Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrapped label and the basic info width #726

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

alexsupa597
Copy link
Contributor

What problem does this PR solve?

There is a common problem in the page account and the page Token, when our page is a two-column layout, adaptive layout makes the first column wider.

Ref: Magickbase/godwoken_explorer#1111

Check List

Test

e2e Test

Task

none

@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
godwoken-explorer-ui ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 4:47AM (UTC)

@alexsupa597 alexsupa597 changed the title Fix:wrapped label and the basic info width Fix: wrapped label and the basic info width Nov 17, 2022
@auto-add-label auto-add-label bot added the Fix label Nov 17, 2022
@alexsupa597 alexsupa597 requested review from Keith-CY, qiweiii and FrederLu and removed request for Keith-CY November 17, 2022 14:48
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #726 (44e4ae9) into develop (beaa0e1) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #726      +/-   ##
===========================================
- Coverage    56.91%   56.81%   -0.11%     
===========================================
  Files           11       11              
  Lines          701      704       +3     
  Branches       423      423              
===========================================
+ Hits           399      400       +1     
- Misses         276      278       +2     
  Partials        26       26              
Impacted Files Coverage Δ
pages/blocks.tsx 7.40% <0.00%> (+3.24%) ⬆️

@FrederLu
Copy link
Contributor

@JeffreyMa597
The width/height of the left and right layout of the page refers to the UI draft. Some pages need to increase in height due to more content, but the width remains the same. Use ellipses if the inner content is too long.
UI draft:https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=0%3A1&t=g3sMX7ZFQA8aWdde-0

The size of Basic Info in Contract Account is different from that of Overview, and both of them are the same size 584x292 on the UI.
https://godwoken-explorer-7rtmr90yl-magickbase.vercel.app/zh-CN/account/0xe05d380839f32bc12fb690aa6fe26b00bd982613

Same issue on Polyjuice Creator Account.
https://godwoken-explorer-7rtmr90yl-magickbase.vercel.app/address/0x829cc5785a4d8ac642ede32cb3cb5cb9dc389d5892f2fc2afc760691445be194

Same issue on Contract Account.
https://godwoken-explorer-7rtmr90yl-magickbase.vercel.app/account/0xe05d380839f32bc12fb690aa6fe26b00bd982613

@alexsupa597
Copy link
Contributor Author

alexsupa597 commented Nov 18, 2022

@JeffreyMa597 The width/height of the left and right layout of the page refers to the UI draft. Some pages need to increase in height due to more content, but the width remains the same. Use ellipses if the inner content is too long.

@FrederLu Fixed.

@alexsupa597 alexsupa597 merged commit 8b1988f into develop Nov 18, 2022
@alexsupa597 alexsupa597 deleted the fix/the-basic-info-width-dimension-is-abnormal branch November 18, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants