Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update style of overlapped token logos #458

Merged
merged 4 commits into from
Aug 24, 2022
Merged

feat: update style of overlapped token logos #458

merged 4 commits into from
Aug 24, 2022

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Aug 16, 2022 •
edited
Loading

Ref: Magickbase/godwoken_explorer#862

image
Left: Before, Right: After

@vercel
Copy link

vercel bot commented Aug 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
godwoken-explorer-ui ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 9:17AM (UTC)

@Keith-CY Keith-CY requested review from FrederLu and qiweiii August 16, 2022 17:22
@Keith-CY Keith-CY mentioned this pull request Aug 17, 2022
Closed
@Keith-CY Keith-CY self-assigned this Aug 18, 2022
@FrederLu
Copy link
Contributor

FrederLu commented Aug 18, 2022 •
edited
Loading

@Keith-CY
https://godwoken-explorer-qdiw3fhqw-nervosnet.vercel.app/account/0x067e469c13a7294d1aafa2130272a9c7b70a4464?tab=assets
In the above link, the single token icon is more to the left than the double toekn icon.
image
image

@Keith-CY
Copy link
Member Author

@FrederLu please have a review

@FrederLu
Copy link
Contributor

FrederLu commented Aug 23, 2022 •
edited
Loading

image

https://godwoken-explorer-lgxrmwv3y-nervosnet.vercel.app/account/0x39784ddab654e8469498cb24ead628e6df644ec9?tab=assets

@Keith-CY
On the new link, the single token is still more to the left than the double token, and it is not centered.

@Keith-CY
Copy link
Member Author

image

godwoken-explorer-lgxrmwv3y-nervosnet.vercel.app/account/0x39784ddab654e8469498cb24ead628e6df644ec9?tab=assets

@Keith-CY On the new link, the single token is still more to the left than the double token, and it is not centered.

Should be fixed by 1ea7511
Preview https://godwoken-explorer-ui-git-align-token-logos-nervosnet.vercel.app/account/0x39784ddab654e8469498cb24ead628e6df644ec9?tab=assets

@Keith-CY Keith-CY merged commit 94d9599 into develop Aug 24, 2022
@Keith-CY Keith-CY deleted the align-token-logos branch August 24, 2022 08:32
Keith-CY added a commit that referenced this pull request Aug 27, 2022
@Keith-CY
feat: update style of overlapped token logos (#458)
26189ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederLu FrederLu FrederLu approved these changes

@qiweiii qiweiii qiweiii approved these changes

Assignees

@Keith-CY Keith-CY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Keith-CY @FrederLu @qiweiii