Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell list on transaction page is scrollable which is unexpected #559

Closed
Keith-CY opened this issue Mar 1, 2024 · 4 comments
Closed

Cell list on transaction page is scrollable which is unexpected #559

Keith-CY opened this issue Mar 1, 2024 · 4 comments
Assignees
@Keith-CY @zmcNotafraid
Labels
bug Something isn't working

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Mar 1, 2024

https://explorer.nervos.org/transaction/0xe2fb199810d49a4d8beec56718ba2593b665db9d52299a0f9e6e75416d73ff5c

image
@Keith-CY Keith-CY added the bug Something isn't working label Mar 1, 2024
@github-actions github-actions bot mentioned this issue Mar 8, 2024
Merged
@Sven-TBD Sven-TBD self-assigned this Mar 11, 2024
@github-actions github-actions bot mentioned this issue Mar 15, 2024
Merged
@github-actions github-actions bot mentioned this issue Apr 19, 2024
Merged
@Keith-CY
Copy link
Member Author

https://mainnet-api.explorer.nervos.org/api/v2/ckb_transactions/0xe2fb199810d49a4d8beec56718ba2593b665db9d52299a0f9e6e75416d73ff5c/display_outputs?page=1&page_size=10

Page_size doesn't work when the transaction is in block 0. The list should be paginated before the scroll is removed. cc @Sven-TBD

Keith-CY added a commit to Magickbase/ckb-explorer-frontend that referenced this issue May 20, 2024
@Keith-CY
feat: remove scroll of cell list
7eb6c74 
Ref: Magickbase/ckb-explorer-public-issues#559
@Keith-CY Keith-CY mentioned this issue May 20, 2024
Merged
@Keith-CY
Copy link
Member Author

PR: Magickbase/ckb-explorer-frontend#341

@github-actions github-actions bot mentioned this issue May 24, 2024
Merged
@zmcNotafraid
Copy link
Member

PR: nervosnetwork/ckb-explorer#1886

@Keith-CY
Copy link
Member Author

Verified

https://explorer.nervos.org/transaction/0xe2fb199810d49a4d8beec56718ba2593b665db9d52299a0f9e6e75416d73ff5c

image

github-merge-queue bot pushed a commit to Magickbase/ckb-explorer-frontend that referenced this issue May 27, 2024
@Keith-CY
feat: remove scroll of cell list (#341)
1da63f5 
Ref: Magickbase/ckb-explorer-public-issues#559
@github-actions github-actions bot mentioned this issue May 31, 2024
Merged
@zmcNotafraid zmcNotafraid mentioned this issue Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keith-CY Keith-CY

@zmcNotafraid zmcNotafraid

Labels
bug Something isn't working
Projects
CKB Explorer
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Keith-CY @devchenyan @zmcNotafraid @FrederLu @Sven-TBD