Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Omnilock of ForceBridge #532

Open
Daryl-L opened this issue Jan 24, 2024 · 4 comments
Open

The Omnilock of ForceBridge #532

Daryl-L opened this issue Jan 24, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Daryl-L
Copy link

Daryl-L commented Jan 24, 2024

History

The Yokai Swap launched in 2022, but at that time, the Force Bridge was using the PW-Lock, which was not supported by Yokai Swap. But at that time, the Omnilock hadn't launched in Mainnet. So we just deployed the Omnilock from the source code which had not been released. And the migration from PW-Lock was also launched for this.

And the Yokai Swap and the Force Bridge are still using this version of Omnilock now.

Dependency

OMNI_LOCK: {
  CODE_HASH: "0x9f3aeaf2fc439549cbc870c653374943af96a0658bd6b51be8d8983183e6f52f",
  HASH_TYPE: "type",
  TX_HASH: "0xaa8ab7e97ed6a268be5d7e26d63d115fa77230e51ae437fc532988dd0c3ce10a",
  INDEX: "0x1",
  DEP_TYPE: "code",
}

Refference

https://forcebridge.com
https://github.com/homura/pw-up/blob/master/src/lib/PwUp.ts
https://www.yokaiswap.com/bridge/deposit
https://pw-up.vercel.app/
https://github.com/nervosnetwork/force-bridge/blob/main/docs/asset-migration-guide.md

@homura
Copy link

homura commented Jan 24, 2024

Is the issue asking the explorer team to add the outdated Omnilock to its known scripts list?

@Keith-CY Keith-CY added the documentation Improvements or additions to documentation label Feb 5, 2024
@Keith-CY
Copy link
Member

Keith-CY commented Feb 5, 2024

Is the issue asking the explorer team to add the outdated Omnilock to its known scripts list?

Yes, this script is used by several dapps, and it was declared an omnilock, but in fact it's a customized one, so it would be better to be annotated.

@Keith-CY
Copy link
Member

Keith-CY commented Feb 5, 2024

@Keith-CY
Copy link
Member

Keith-CY commented Feb 8, 2024

The PR will be merged first, the link to the code will be added after the Chinese New Year.

The link to the code should point to the git commit which was deployed on the chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 📫Hold On
Development

No branches or pull requests

3 participants