Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show holder_count in ckb_hodl_wave chart #405

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

zmcNotafraid
Copy link
Member

No description provided.

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 2:50am

@Keith-CY Keith-CY requested a review from FrederLu July 19, 2024 03:15
@FrederLu
Copy link

FrederLu commented Jul 19, 2024

image image
  1. By observing on the Charts page, the coordinate color on the left of CKB HODL Wave is different from other coordinates, which can be unified here.
  2. In terms of color, 24h and holder count are the same color. It is better to use different colors to distinguish them.
  3. Compared to 1d-1w, 1w-1m or 1m-3m, the line widths of 24h and holder count are larger than them and can be kept consistent with other line widths.
    cc @Sven-TBD

@Keith-CY
Copy link
Member

image image

  1. By observing on the Charts page, the coordinate color on the left of CKB HODL Wave is different from other coordinates, which can be unified here.
  2. In terms of color, 24h and holder count are the same color. It is better to use different colors to distinguish them.
  3. Compared to 1d-1w, 1w-1m or 1m-3m, the line widths of 24h and holder count are larger than them and can be kept consistent with other line widths.
    cc @Sven-TBD

@Sven-TBD please check

@poor-defined
Copy link

  1. By observing on the Charts page, the coordinate color on the left of CKB HODL Wave is different from other coordinates, which can be unified here.

@zmcNotafraid Hi MingChang, could you help with this?

  1. In terms of color, 24h and holder count are the same color. It is better to use different colors to distinguish them.

Yes, they should be distinguished , we could change the color of the holder count line , it should be more noticeable.

  1. Compared to 1d-1w, 1w-1m or 1m-3m, the line widths of 24h and holder count are larger than them and can be kept consistent with other line widths.

We can remain this change , coz this line should be different from other lines which work as division lines.

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@Keith-CY Keith-CY added this pull request to the merge queue Jul 25, 2024
Merged via the queue into Magickbase:develop with commit 73b5a4f Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants