Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(digest): mobile abnormal digest padding #302

Merged
merged 4 commits into from
May 23, 2024
Merged

fix(digest): mobile abnormal digest padding #302

merged 4 commits into from
May 23, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented May 9, 2024

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 9:39am

@Daryl-L Daryl-L mentioned this pull request May 9, 2024
Closed
@FrederLu
Copy link

image

https://ckb-explorer-frontend-in-magickbase-repo-4fm95lsnx-magickbase.vercel.app/transaction/0x5639d2f490a742b81ef01743cba7096b95187bc9da0d38025fb0261463c82d87

image image

Comparing the UI screenshots in the issue, problems 2 and 3 still exist.If one line cannot be displayed, multiple lines must be displayed on the mobile terminal.
please confirm.

@Keith-CY
Copy link
Member

Please have a check @FrederLu

@FrederLu
Copy link

https://ckb-explorer-frontend-in-magickbase-repo-pzx1y3ne9-magickbase.vercel.app/transaction/0x6d5ae8a083158e2d9945dd3d43b6c9d2e9ebb1b2b5fa41b3a0d1042d314d2f29
image
The data for Seal Tx On Bitcoin requires the use of system colors.

@Daryl-L Daryl-L force-pushed the fix/mobile-abnormal-digest branch from d0af543 to aaea249 Compare May 23, 2024 07:26
@Daryl-L Daryl-L force-pushed the fix/mobile-abnormal-digest branch from aaea249 to 5f488e6 Compare May 23, 2024 07:39
@FrederLu
Copy link

https://ckb-explorer-frontend-in-magickbase-repo-pzx1y3ne9-magickbase.vercel.app/transaction/0x6d5ae8a083158e2d9945dd3d43b6c9d2e9ebb1b2b5fa41b3a0d1042d314d2f29 image The data for Seal Tx On Bitcoin requires the use of system colors.

This problem still exists.

@Keith-CY Keith-CY merged commit 4988a34 into develop May 23, 2024
8 checks passed
@Keith-CY Keith-CY deleted the fix/mobile-abnormal-digest branch May 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@FrederLu FrederLu FrederLu approved these changes

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daryl-L @FrederLu @Keith-CY