Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(address): fix the nrc721 not displayed in the assets list #289

Merged
merged 5 commits into from
May 11, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Apr 12, 2024

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:14am

@Keith-CY Keith-CY requested a review from FrederLu April 29, 2024 03:51
@FrederLu
Copy link

FrederLu commented Apr 30, 2024

@Daryl-L
Copy link
Author

Daryl-L commented Apr 30, 2024

https://ckb-explorer-frontend-in-magickbase-repo-h3q4ska0l-magickbase.vercel.app/nft-collections/0xcfd1fcdc7f3bf8486ca1bd84382ea6c16f6d6e0c8f03ba9b67e1c4d2296ff132 image

https://ckb-explorer-frontend-in-magickbase-repo-h3q4ska0l-magickbase.vercel.app/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxqvxn7gje034tgxnku60dym868umlnapl3g3unawn image

Now there is data under Simple User Defined Token, but we need to confirm that the displayed data is mostly ?. Is it related to this modification? At the same time, there is no information about asd on the address.

No, I think not, because they are not displayed before. And the data from api is null for these informations
image

@FrederLu
Copy link

FrederLu commented Apr 30, 2024

@Keith-CY
Copy link
Member

Keith-CY commented May 9, 2024

@poor-defined
Copy link

According to the content in the channel, the solution proposed in this issue can be divided into 2 steps:

  1. Display the NRC721 cell according to the protocol rules in the UDT Tab as live cells tab does; Backend @zmcNotafraid front-end @Daryl-L
  2. An update for an exceptional state (see the new UI in the way to display the info of NRC721 lacking factory cell. ckb-explorer-public-issues#642 (comment)) @devchenyan @Daryl-L You can discuss and decide who should take this.

@Keith-CY Keith-CY merged commit bcda583 into develop May 11, 2024
8 checks passed
@Keith-CY Keith-CY deleted the fix/nrc721-not-display branch May 11, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants