Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add calculator for DAO rewards #275

Merged
merged 9 commits into from
Apr 3, 2024
Merged

Conversation

devchenyan
Copy link

@devchenyan devchenyan commented Mar 28, 2024

issue: Magickbase/ckb-explorer-public-issues#462

pc:

Screen-2024-03-28-143910.mp4

mobile:

Screen-2024-03-28-144100.mp4

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 3:41am

@silySuper
Copy link

silySuper commented Mar 28, 2024

1.Actual page is different from UI design
Actual page:
截屏2024-03-28 16 47 22

UI design:
截屏2024-03-28 16 49 19

2.Address page transaction number shows 0,but actual has transactions @Daryl-L

2024-03-28.16.52.46.mov
截屏2024-03-28 16 51 20

@devchenyan
Copy link
Author

1.Actual page is different from UI design Actual page: 截屏2024-03-28 16 47 22

UI design: 截屏2024-03-28 16 49 19

2.Address page transaction number shows 0,but actual has transactions @Daryl-L

2024-03-28.16.52.46.mov
截屏2024-03-28 16 51 20

  1. There shouldn't be a slider here because the browser, unlike in neuron, has a limit of values that the user can deposit at most. Please update the design @Sven-TBD

  2. This should be fixed on the rgb++ branch @Daryl-L

@silySuper
Copy link

1.OK,In Nervos DAO Reward Calculator page, I find that it can not input decimals when I click . in keyboard.

@devchenyan
Copy link
Author

1.OK,In Nervos DAO Reward Calculator page, I find that it can not input decimals when I click . in keyboard.

fixed, please check it @silySuper

@Keith-CY
Copy link
Member

Keith-CY commented Apr 2, 2024

image Deposit 1000 CKB but withdraw 1.7 CKB is misleading, expected to be 1001.7 CKB

Signed-off-by: Chen Yu <keithwhisper@gmail.com>
The compensation should be compound
@Keith-CY
Copy link
Member

Keith-CY commented Apr 3, 2024

I've made the following updates

  1. Use compensation instead of reward because compensation is generally used in Nervos DAO as rewards, e.g. the term APC is short for Annual Percentage Compensation, it avoids the attribute of finance.

  2. The duration of charts is configurable

image

In the design, the duration is fixed to 1 month, which has been displayed above
image
It's unnecessary to repeat it in the chart again.

@Keith-CY
Copy link
Member

Keith-CY commented Apr 3, 2024

This function has been reviewed by some users and got positive feedback. Will be pushed to testnet first for more feedback.

@Keith-CY Keith-CY merged commit 9d0e75b into develop Apr 3, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/calculator-for-dao branch April 3, 2024 06:34
@Keith-CY
Copy link
Member

Keith-CY commented Apr 3, 2024

Feel free to open a new issue if any problems should be fixed from your perspective @silySuper
I merged it because it looks good to me enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants