Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update 0046-walletconnect-namespaces.md #1

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Aug 18, 2023

  1. Update the RFC number;
  2. Adjust the order of the example to match sections below;
  3. Rename chainId as reference that used in https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-2.md
  4. Rename chainId as chain_id that used in https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-10.md
  5. Fix the reference to a script from code hash to code hash + hash type

@Keith-CY
Copy link
Member Author

I also found some missing details

  1. the method to connect the wallet is missing
  2. Types Address and Transaction are mentioned but not defined in the doc
  3. In the section ckb_getAddresses, type: derived | all is mentioned but not explained. It's the concept specifically in this RFC and is not explained elsewhere.
  4. changeType: add | consume is mentioned in the addressesChanged section but is not explained

Signed-off-by: Chen Yu <keithwhisper@gmail.com>
@Keith-CY Keith-CY force-pushed the update-walletconnect-namespace branch from d0fc518 to cb23c23 Compare August 18, 2023 06:52
@Keith-CY Keith-CY requested a review from WhiteMinds August 18, 2023 06:53
@devchenyan devchenyan merged commit ea10b12 into feat-sdk Aug 18, 2023
@devchenyan
Copy link
Collaborator

I also found some missing details

  1. the method to connect the wallet is missing
  2. Types Address and Transaction are mentioned but not defined in the doc
  3. In the section ckb_getAddresses, type: derived | all is mentioned but not explained. It's the concept specifically in this RFC and is not explained elsewhere.
  4. changeType: add | consume is mentioned in the addressesChanged section but is not explained

There is no need to define method connect in namespaces.

@Keith-CY Keith-CY deleted the update-walletconnect-namespace branch August 21, 2023 06:13
@Keith-CY
Copy link
Member Author

I also found some missing details

  1. the method to connect the wallet is missing
  2. Types Address and Transaction are mentioned but not defined in the doc
  3. In the section ckb_getAddresses, type: derived | all is mentioned but not explained. It's the concept specifically in this RFC and is not explained elsewhere.
  4. changeType: add | consume is mentioned in the addressesChanged section but is not explained

There is no need to define method connect in namespaces.

Where should I check the information about

  sessionProperties: {
    lockCodeHashes: "secp256k1,acp",
  },

to set required script_base on connecting to the wallet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants