-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to ESLint v9 and flat config #3558
Conversation
1deb0a5
to
c9d75a9
Compare
Don't worry, I just wanted to start coding the tests with eslint v9. |
to be honest I have no clue about eslint but with this PR we have "dependencies": {
"eslint": "^9.11.1",
},
"devDependencies": {
"@eslint/js": "^9.11.1",
}, in Is this correct or would be the one under |
So everything is fine in my eyes. |
Thanks for the explanation, I checked for dependency updates and saw the same update for both ... |
The developers seem to synchronize the version number of both. So we will be seeing this even more often in the future. I understand the doubt 🙂 They should have found a better name for the plugin. |
hm, I tested now without the |
Yes, it works because the plugin is a dependency of ESLint. https://github.com/eslint/eslint/blob/main/package.json#L104 Isn't it recommended to put direct dependencies into the package.json? We import the plugin in the ESLint config. |
eslint-plugin-import was missing since the switch to [v9](#3558). They finally [support](import-js/eslint-plugin-import#2996) it so we can re-add it.
Since PR #3551 was not yet complete, I made my own attempt.
.eslintrc.json
and.eslintignore
by flat configeslint.config.mjs
.check_config.js
to use flat config.eslint-plugin-import
still doesn't support ESLint v9 I removed it. We can add it back when it does support v9.npm run check:js
andnpm run config:check
.@eslint/js
.@bugsounet, please don't take it as an offence that I have created a competing PR. The migration to ESLint v9 has been burning under my nails for some time.