Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix envcanada today pop #3106

Merged
merged 2 commits into from
May 21, 2023
Merged

Fix envcanada today pop #3106

merged 2 commits into from
May 21, 2023

Conversation

eddiehung
Copy link
Contributor

Fix for today's probability-of-precipitation weather module's envcanada provider.

Without which, requesting showPrecipitationProbability causes "undefined" to be shown.

Consistent with method used elsewhere in the file:
https://github.com/MichMich/MagicMirror/blob/abe5c08a52ffee6b37c30c1f3160e130f0e966a2/modules/default/weather/providers/envcanada.js#L395-L399

@codecov-commenter
Copy link

Codecov Report

Merging #3106 (69a12be) into develop (babd22b) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3106      +/-   ##
===========================================
+ Coverage    25.61%   25.65%   +0.04%     
===========================================
  Files           53       53              
  Lines        11427    11427              
===========================================
+ Hits          2927     2932       +5     
+ Misses        8500     8495       -5     
Impacted Files Coverage Δ
modules/default/weather/providers/envcanada.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@rejas rejas merged commit 0573d6e into MagicMirrorOrg:develop May 21, 2023
@eddiehung eddiehung deleted the patch-1 branch October 30, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants