-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP headers with CORS-method #2957
Support HTTP headers with CORS-method #2957
Conversation
A separate file makes it easier to test. Added unit tests to the cors-method.
d791a94
to
351433b
Compare
The tests fail because GitHub uses a different node-version. GitHub uses 16.17.1, whilst I used 19.0.0 locally. Will try to implement the tests to run on both. |
we are running the tests here on 3 node version, 14+16+18. Our fetch function uses the internal fetch of Node if Node version >=18 and |
351433b
to
5c044fc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2957 +/- ##
===========================================
- Coverage 65.28% 63.72% -1.57%
===========================================
Files 14 15 +1
Lines 726 758 +32
===========================================
+ Hits 474 483 +9
- Misses 252 275 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5c044fc
to
8588044
Compare
Yep, working now 👍 |
43dcfc1
to
f0319c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small things only
f0319c2
to
e38c61f
Compare
This is required for some weather-providers, and will probably be useful for other services.
e38c61f
to
ccc6732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ccc6732
to
68e321b
Compare
Adds support for sending and receiving HTTP-headers when using the CORS-method.
This change is required for the Yr weather-provider introduced in #2948.
To make it easier to add unit tests I moved the server-functions into a separate file.