-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve tests #2923
improve tests #2923
Conversation
Thanks for your work. One favor I have to ask: Could you split the weather tests into two files, weather_current_spec and weather_forecast_spec? Would help me a lot when cleaning them up in my weather refactor later. |
Codecov Report
@@ Coverage Diff @@
## develop #2923 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! SO much cleaner now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and eager to have it merged @MichMich :-)
🎉 |
use es6 syntax in all tests, split weather tests, remove callbacks