Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type value in weatherbit provider #2900

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Aug 17, 2022

... which is the documented way of configuring a provider instead of relying on undocumented weatherEndpoint param.

Fixes #2899

@rejas rejas changed the base branch from master to develop August 17, 2022 07:20
@codecov-commenter
Copy link

Codecov Report

Merging #2900 (2c0c62c) into develop (4d8fb8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2900   +/-   ##
========================================
  Coverage    63.82%   63.82%           
========================================
  Files            9        9           
  Lines          293      293           
========================================
  Hits           187      187           
  Misses         106      106           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weather module, weatherbit provider doesn't use type to set the endpoint, forces user..
3 participants