Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log output #2814

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Fix log output #2814

merged 2 commits into from
Feb 20, 2022

Conversation

KristjanESPERANTO
Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO commented Feb 20, 2022

Console output before:

alert - Load translationfalse: translations/de.json
alert - Load translation fallback: translations/bg.json

Console output after:

alert - Load translation: translations/de.json
alert - Load translation fallback: translations/bg.json

Before:
```
MMM-OlympicGames - Load translationfalse: translations/de.json
translator.js:107 MMM-OlympicGames - Load translation  fallback: translations/en.json
```

After:
```
MMM-OlympicGames - Load translation: translations/de.json
translator.js:107 MMM-OlympicGames - Load translation fallback: translations/en.json
```
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #2814 (7ca5d81) into develop (880e216) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2814   +/-   ##
========================================
  Coverage    65.26%   65.26%           
========================================
  Files            8        8           
  Lines          285      285           
========================================
  Hits           186      186           
  Misses          99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880e216...7ca5d81. Read the comment docs.

@KristjanESPERANTO KristjanESPERANTO marked this pull request as ready for review February 20, 2022 01:31
Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@MichMich MichMich merged commit 81ae95e into MagicMirrorOrg:develop Feb 20, 2022
@KristjanESPERANTO KristjanESPERANTO deleted the patch-2 branch February 20, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants