Bug fix to correctly handle the logic for 'maxEntries' Issue #2050 #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejas
reviewed
Jun 20, 2020
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ❤️ **Donate:** Enjoying MagicMirror²? [Please consider a donation!](https://magicmirror.builders/donate) With your help we can continue to improve the MagicMirror² | |||
|
|
|||
| ## [20.11.1] - 2020-06-20 | |||
There was a problem hiding this comment.
I guess you will have let @MichMich to decide if a bugfix release will happen for that...
There was a problem hiding this comment.
Ok. I only added this because the guidelines suggested me to edit the changelog. I'm happy to revert this change if needed.
|
Please add the changelog to the 2.12 entry. Thanks. |
|
@MichMich: I updated the version to 2.12.0 - is that what you're suggesting? |
|
Have you started your work from the master or the develop branch? Seems like the former which leads to these merge conflicts. |
|
Ah, sorry about that - I had started from master. Should I just abort this pull request and submit a new one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Removes the logic of filtering events by
maxEntriesfrom calendarfetcher.js** Results in the logic of filtering to solely be done in calendar.js