Skip to content

Commit

Permalink
Fix: composer
Browse files Browse the repository at this point in the history
  • Loading branch information
@NicolasAndersen
NicolasAndersen committed Jan 20, 2016
1 parent aa06eaf commit 75ba504
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/code/Magestore/Bannerslider/composer.json
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "magestore/module-bannerslider",
"name": "magestore/Bannerslider-Magento2",

This comment has been minimized.

Sign in to view

Copy link
@pivulic

pivulic Jan 20, 2016

Contributor

Why was the composer name changed from magestore/module-bannerslider? This doesn't correlate with the naming convention in Magento 2 core modules, see vendor/magento/, i.e. vendor/magento/module-catalog and it's composer.json name.
"description": "N/A",
"require": {
"php": "~5.5.0|~5.6.0|~7.0.0",
"magento/framework": "1.0.0-beta",
"magento/framework": "100.0.*",
"lib-libxml": "*"
},
"type": "magento2-module",
Expand Down

0 comments on commit 75ba504

Please sign in to comment.