forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SIEM] Fixes test flakiness (elastic#65510)
* adds 'Configures a new connector' test * refactor code * updates configure_cases screen selectors * removes 'configure connector' test flakiness
- Loading branch information
1 parent
4619b47
commit b4940e2
Showing
7 changed files
with
155 additions
and
4 deletions.
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
x-pack/plugins/siem/cypress/integration/cases_connectors.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
import { serviceNowConnector } from '../objects/case'; | ||
|
||
import { TOASTER } from '../screens/configure_cases'; | ||
|
||
import { goToEditExternalConnection } from '../tasks/all_cases'; | ||
import { | ||
addServiceNowConnector, | ||
openAddNewConnectorOption, | ||
saveChanges, | ||
selectLastConnectorCreated, | ||
} from '../tasks/configure_cases'; | ||
import { loginAndWaitForPageWithoutDateRange } from '../tasks/login'; | ||
|
||
import { CASES } from '../urls/navigation'; | ||
|
||
describe('Cases connectors', () => { | ||
before(() => { | ||
cy.server(); | ||
cy.route('POST', '**/api/action').as('createConnector'); | ||
cy.route('POST', '**/api/cases/configure').as('saveConnector'); | ||
}); | ||
|
||
it('Configures a new connector', () => { | ||
loginAndWaitForPageWithoutDateRange(CASES); | ||
goToEditExternalConnection(); | ||
openAddNewConnectorOption(); | ||
addServiceNowConnector(serviceNowConnector); | ||
|
||
cy.wait('@createConnector') | ||
.its('status') | ||
.should('eql', 200); | ||
cy.get(TOASTER).should('have.text', "Created 'New connector'"); | ||
|
||
selectLastConnectorCreated(); | ||
saveChanges(); | ||
|
||
cy.wait('@saveConnector', { timeout: 10000 }) | ||
.its('status') | ||
.should('eql', 200); | ||
cy.get(TOASTER).should('have.text', 'Saved external connection settings'); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
export const ADD_NEW_CONNECTOR_OPTION_LINK = | ||
'[data-test-subj="case-configure-add-connector-button"]'; | ||
|
||
export const CONNECTOR = (id: string) => { | ||
return `[data-test-subj='dropdown-connector-${id}']`; | ||
}; | ||
|
||
export const CONNECTOR_NAME = '[data-test-subj="nameInput"]'; | ||
|
||
export const CONNECTORS_DROPDOWN = '[data-test-subj="dropdown-connectors"]'; | ||
|
||
export const PASSWORD = '[data-test-subj="connector-servicenow-password-form-input"]'; | ||
|
||
export const SAVE_BTN = '[data-test-subj="saveNewActionButton"]'; | ||
|
||
export const SAVE_CHANGES_BTN = '[data-test-subj="case-configure-action-bottom-bar-save-button"]'; | ||
|
||
export const SERVICE_NOW_CONNECTOR_CARD = '[data-test-subj=".servicenow-card"]'; | ||
|
||
export const TOASTER = '[data-test-subj="euiToastHeader"]'; | ||
|
||
export const URL = '[data-test-subj="apiUrlFromInput"]'; | ||
|
||
export const USERNAME = '[data-test-subj="connector-servicenow-username-form-input"]'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { | ||
ADD_NEW_CONNECTOR_OPTION_LINK, | ||
CONNECTOR, | ||
CONNECTOR_NAME, | ||
CONNECTORS_DROPDOWN, | ||
PASSWORD, | ||
SAVE_BTN, | ||
SAVE_CHANGES_BTN, | ||
SERVICE_NOW_CONNECTOR_CARD, | ||
URL, | ||
USERNAME, | ||
} from '../screens/configure_cases'; | ||
import { MAIN_PAGE } from '../screens/siem_main'; | ||
|
||
import { Connector } from '../objects/case'; | ||
|
||
export const addServiceNowConnector = (connector: Connector) => { | ||
cy.get(SERVICE_NOW_CONNECTOR_CARD).click(); | ||
cy.get(CONNECTOR_NAME).type(connector.connectorName); | ||
cy.get(URL).type(connector.URL); | ||
cy.get(USERNAME).type(connector.username); | ||
cy.get(PASSWORD).type(connector.password); | ||
cy.get(SAVE_BTN).click({ force: true }); | ||
}; | ||
|
||
export const openAddNewConnectorOption = () => { | ||
cy.get(MAIN_PAGE).then($page => { | ||
if ($page.find(SERVICE_NOW_CONNECTOR_CARD).length !== 1) { | ||
cy.wait(1000); | ||
cy.get(ADD_NEW_CONNECTOR_OPTION_LINK).click({ force: true }); | ||
} | ||
}); | ||
}; | ||
|
||
export const saveChanges = () => { | ||
cy.get(SAVE_CHANGES_BTN).click(); | ||
}; | ||
|
||
export const selectLastConnectorCreated = () => { | ||
cy.get(CONNECTORS_DROPDOWN).click({ force: true }); | ||
cy.get('@createConnector') | ||
.its('response') | ||
.then(response => { | ||
cy.get(CONNECTOR(response.body.id)).click(); | ||
}); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters