Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dense Cholesky #89

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Add support for dense Cholesky #89

merged 1 commit into from
Sep 20, 2021

Conversation

sshin23
Copy link
Member

@sshin23 sshin23 commented Sep 17, 2021

This PR adds cholesky option to MadNLPLapackCPU and MadNLPLapackGPU.

@sshin23 sshin23 requested a review from frapac September 17, 2021 21:08
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #89 (fca252a) into master (4633bf9) will increase coverage by 0.21%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   87.50%   87.72%   +0.21%     
==========================================
  Files          28       28              
  Lines        3249     3290      +41     
==========================================
+ Hits         2843     2886      +43     
+ Misses        406      404       -2     
Impacted Files Coverage Δ
lib/MadNLPGPU/src/lapackgpu.jl 81.03% <86.95%> (+2.90%) ⬆️
src/LinearSolvers/lapack.jl 97.56% <95.65%> (-0.48%) ⬇️
lib/MadNLPHSL/src/ma86.jl 84.90% <0.00%> (+3.77%) ⬆️
lib/MadNLPHSL/src/ma97.jl 84.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4633bf9...fca252a. Read the comment docs.

@sshin23 sshin23 merged commit 9cf175c into master Sep 20, 2021
frapac pushed a commit to frapac/MadNLP.jl that referenced this pull request Sep 20, 2021
@sshin23 sshin23 deleted the ss/cholesky branch July 5, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant