kkt error reduction #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshin23
force-pushed
the
ss/kkt-error-reduction
branch
from
72daaa2
to
9016ae9
Compare
sshin23
force-pushed
the
ss/kkt-error-reduction
branch
from
9016ae9
to
03c3824
Compare
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 87.36% 87.62% +0.26%
==========================================
Files 28 28
Lines 3181 3249 +68
==========================================
+ Hits 2779 2847 +68
Misses 402 402
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we had KKT error reduction phase (Section 3.3.2), but dropped the support some time in the past. But the KKT error reduction phase seems to be giving us some substantial performance gain benchmark.pdf. So we bring it back in this PR