Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LapackCPU in MINLPTests #81

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Use LapackCPU in MINLPTests #81

merged 1 commit into from
Sep 14, 2021

Conversation

sshin23
Copy link
Member

@sshin23 sshin23 commented Sep 14, 2021

MINLPTests.jl have some nonconvex NLPs, and there have been issue of Umfpack converging to a different local solution. This is OK, but this makes the test fail in some instances. This is probably because Umfpack uses the inertia-free method and different regularization method alters the path of iterates. Now we use MadNLPLapackCPU (which reveals inertia) to avoid this behavior.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #81 (e08f278) into master (597bccb) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   87.21%   87.18%   -0.04%     
==========================================
  Files          28       28              
  Lines        3184     3184              
==========================================
- Hits         2777     2776       -1     
- Misses        407      408       +1     
Impacted Files Coverage Δ
lib/MadNLPHSL/src/ma77.jl 85.52% <0.00%> (-2.64%) ⬇️
src/LinearSolvers/lapack.jl 98.03% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 597bccb...e08f278. Read the comment docs.

@sshin23 sshin23 merged commit 83ba7fa into master Sep 14, 2021
@sshin23 sshin23 deleted the ss/test-lapack branch July 5, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant