Optimize copy of a SparseMatrixCOO to a dense matrix #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are breaking because of IterativeSolvers. See PR #34 |
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 19 19
Lines 2634 2634
=======================================
Hits 2274 2274
Misses 360 360
Continue to review full report at Codecov.
|
|
@frapac Thanks for working on this! Later I think later we should separately define a dense nonlinear program type and natively support dense NLPs. But for now, this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When solving dense nonlinear optimization problem, copying a
SparseMatrixCOOto a dense array amount to up to 11% of the total running time inMadNLP.optimize!. This PR should add an@inboundsmacro to optimize the function_copyto!