Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CuDSS synchronize added #314

Merged
merged 2 commits into from
Mar 27, 2024
Merged

CuDSS synchronize added #314

merged 2 commits into from
Mar 27, 2024

Conversation

sshin23
Copy link
Member

@sshin23 sshin23 commented Mar 27, 2024

Now we synchronize CUDABackend after factorize/solve with CUDSS. This fixes the timing inconsistency issue

Copy link
Collaborator

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just made a comment, but that's also something we can address in a separate PR.

lib/MadNLPGPU/src/cudss.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.89%. Comparing base (cf6e6be) to head (b391cc2).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   69.80%   69.89%   +0.09%     
==========================================
  Files          39       40       +1     
  Lines        3888     3897       +9     
==========================================
+ Hits         2714     2724      +10     
+ Misses       1174     1173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sshin23 sshin23 merged commit de04e2a into master Mar 27, 2024
7 checks passed
@sshin23 sshin23 deleted the ss/synchronize branch March 31, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants