Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NLPModels and SolverCore #31

Merged
merged 4 commits into from
May 14, 2021
Merged

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented May 6, 2021

No description provided.

@frapac frapac requested a review from sshin23 May 6, 2021 08:58
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #31 (86c96d8) into master (e244709) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          19       19           
  Lines        2634     2634           
=======================================
  Hits         2274     2274           
  Misses        360      360           
Impacted Files Coverage Δ
src/MadNLP.jl 75.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e244709...86c96d8. Read the comment docs.

@sshin23
Copy link
Member

sshin23 commented May 6, 2021

Thanks for the housekeeping 👍

Anything else to include here?

@frapac
Copy link
Collaborator Author

frapac commented May 7, 2021

Before merging this PR, I think I should ensure that the cutest-minlp tests are passing. Apparently, we have a problem with the NLPModels version...

@frapac
Copy link
Collaborator Author

frapac commented May 10, 2021

Tests are finally passing 🎉

@sshin23 sshin23 merged commit 2c220fc into MadNLP:master May 14, 2021
@sshin23
Copy link
Member

sshin23 commented May 14, 2021

@frapac Sorry for checking this late. Merging this to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants