Fix invalid return code in MOI.TerminationStatus #241
Conversation
| if haskey(_STATUS_CODES, model.result.status) | ||
| return _STATUS_CODES[model.result.status] | ||
| else | ||
| return MOI.UNKNOWN_RESULT_STATUS |
There was a problem hiding this comment.
This was a ResultStatusCode, but it must be a TerminationStatusCode.
There was a problem hiding this comment.
Thank you. The changes look good to me. The issue with the invalid values in the Hessian has been fixed in #243 . Once the tests are passing, I would suggest merging this PR before merging #243. We should update the test accordingly:
https://github.com/MadNLP/MadNLP.jl/blob/fp/fix_nan_initial_multipliers/test/MOI_interface_test.jl#L80-L95
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 74.03% 74.44% +0.40%
==========================================
Files 38 38
Lines 3871 3878 +7
==========================================
+ Hits 2866 2887 +21
+ Misses 1005 991 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bug reported on discourse: https://discourse.julialang.org/t/how-to-access-the-exit-of-madnlp-solver-directly/93685