Make nlp a concretely typed field in MadNLPSolver
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, all accesses to fields on `ips.nlp` were type unstable and caused allocations.
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 74.33% 74.33%
=======================================
Files 37 37
Lines 3674 3674
=======================================
Hits 2731 2731
Misses 943 943
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
frapac
reviewed
Sep 1, 2022
There was a problem hiding this comment.
This overall looks good to me. It was something on our todo list, but haven't found the time to fix this. The question is about whether we should allow MadNLP to support very corner cases, as changing entirely the model between two consecutive solves. I guess the answer is not.
Medium-term, it would be nice to update the structure to be immutable as well.
src/IPM/IPM.jl
Outdated
| @@ -5,8 +5,8 @@ abstract type AbstractMadNLPSolver{T} end | |||
|
|
|||
| include("restoration.jl") | |||
|
|
|||
| mutable struct MadNLPSolver{T,KKTSystem <: AbstractKKTSystem{T}} <: AbstractMadNLPSolver{T} | |||
| nlp::AbstractNLPModel | |||
| mutable struct MadNLPSolver{T,KKTSystem <: AbstractKKTSystem{T}, N <: AbstractNLPModel} <: AbstractMadNLPSolver{T} | |||
There was a problem hiding this comment.
I would suggest renaming the type N as Model
There was a problem hiding this comment.
This has been done in
bb93607
baggepinnen
commented
Sep 2, 2022
sshin23
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, all accesses to fields on
ips.nlpwere type unstable and caused allocations.