Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart.md #208

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Update quickstart.md #208

merged 2 commits into from
Aug 30, 2022

Conversation

baggepinnen
Copy link
Contributor

The name appears to have changed

Copy link
Collaborator

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix!

@frapac frapac merged commit e8cd55c into MadNLP:master Aug 30, 2022
@baggepinnen
Copy link
Contributor Author

There are actually several other things that appear to have changed

ips = MadNLP.MadNLPSolver(nlp)
ips.x

appears to contain both variables and Lagrange multipliers, and ips.l does not exist?

Documenter.jl has a mechanism to run code in the docs and throw an error if it fails, it's a nice way to make sure the documentation is kept up to date.

@frapac
Copy link
Collaborator

frapac commented Aug 30, 2022

I am currently working on it. This is on me: we have updated the tutorials to use @example code blocks, but I forgot to update quickstart.md...

@baggepinnen baggepinnen deleted the patch-1 branch August 30, 2022 13:58
@frapac frapac mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants