Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functions to decompose the time spent in callbacks/linear solver #200

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Aug 15, 2022

No description provided.

@frapac frapac requested a review from sshin23 August 15, 2022 20:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #200 (1180dc0) into master (254d29a) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   75.87%   75.99%   +0.11%     
==========================================
  Files          38       38              
  Lines        3457     3474      +17     
==========================================
+ Hits         2623     2640      +17     
  Misses        834      834              
Impacted Files Coverage Δ
src/utils.jl 83.78% <100.00%> (+15.36%) ⬆️
src/MadNLP.jl 57.14% <0.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@sshin23 sshin23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks handy! Thanks for the PR @frapac

One question though, wouldn't it be better to return the result as a named tuple?

@frapac
Copy link
Collaborator Author

frapac commented Aug 16, 2022

right, named tuples should be more intuitive to use!

@frapac frapac merged commit e739a3b into master Aug 18, 2022
@frapac frapac deleted the fp/diagnostic branch August 18, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants