Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port MadNLP to MOI 0.10 and JuMP 0.22 #117

Merged
merged 11 commits into from
Mar 8, 2022
Merged

Port MadNLP to MOI 0.10 and JuMP 0.22 #117

merged 11 commits into from
Mar 8, 2022

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Nov 10, 2021

  • MadNLPGraph is not yet compatible with JuMP 0.22
  • MINLPTests's tests have been commented out: they are passing, but MINLPTests requires JuMP 0.22 too

@frapac frapac requested a review from sshin23 November 10, 2021 10:03
@frapac
Copy link
Collaborator Author

frapac commented Nov 10, 2021

For MINLPTests: jump-dev/MINLPTests.jl#34

@frapac
Copy link
Collaborator Author

frapac commented Feb 7, 2022

MadNLPGraph is now working with JuMP 0.22 and Plasmo 0.4.3. However, I am not sure to understand where does the current error comes from in the tests ...

@blegat
Copy link

blegat commented Mar 5, 2022

Just a notice that we will release JuMP v1.0 in a few days

@frapac
Copy link
Collaborator Author

frapac commented Mar 5, 2022

Thanks for the reminder! This PR is ready to merge, we can make a new release for MadNLP with MOI 1.0 in the next few days.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #117 (b4541dc) into master (2714574) will decrease coverage by 6.21%.
The diff coverage is 76.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   87.55%   81.33%   -6.22%     
==========================================
  Files          31       31              
  Lines        3382     3392      +10     
==========================================
- Hits         2961     2759     -202     
- Misses        421      633     +212     
Impacted Files Coverage Δ
src/Interfaces/MOI_interface.jl 72.48% <72.05%> (-11.60%) ⬇️
lib/MadNLPGraph/src/plasmo_interface.jl 93.30% <100.00%> (+0.12%) ⬆️
lib/MadNLPGPU/src/lapackgpu.jl 0.00% <0.00%> (-80.18%) ⬇️
lib/MadNLPGPU/src/kernels.jl 0.00% <0.00%> (-65.00%) ⬇️
lib/MadNLPHSL/src/ma97.jl 80.00% <0.00%> (-4.00%) ⬇️
src/KKT/dense.jl 100.00% <0.00%> (ø)
src/interiorpointsolver.jl 95.56% <0.00%> (+0.48%) ⬆️
src/MadNLP.jl 62.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef6975...b4541dc. Read the comment docs.

@frapac
Copy link
Collaborator Author

frapac commented Mar 8, 2022

Finally, tests are passing!

@frapac frapac merged commit b884aa2 into master Mar 8, 2022
@frapac frapac deleted the fp/moi_10 branch March 8, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants