Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak build for freebsd 'sed' and wheel version check #130

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

mattip
Copy link
Collaborator

@mattip mattip commented Jan 29, 2024

A few problems appeared in the builds:

  • macos sed does not have a \0 output group for the whole match, use a capture group and \1 instead
  • tweak the wheel build version comparison, it choked on a .dev suffix`
  • no need for a sub-sub version specifier, I did not upload the wheels. Before the upload, both NumPy and SciPy should have a pin so the wheel version update can be done in a controlled fashion.

@mattip mattip merged commit 4a1cb5d into MacPython:main Jan 29, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant