-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
replaces #70. This is much simpler now that multibuild support has improved. |
Hmm. manylinux2014 does not support the openblas-manylinux1 gfortran lib. That means if we try to merge this to use the other architectures (which only support manylinxu2014) we cannot build 1.18 since it uses the old manylinux1 openblas libs :( |
No need to update 1.18 with new libraries and platforms. 1.19 will branch in three months. |
Ok, for now leaving out the |
Of course all the new architectures (aarch64, ppc64le, s390x, pypy on linux64, linux32, macOS) fail to pass. Will work on it offline where I can. |
The PyPy failures will be fixed by numpy/numpy#15750. The ARM64 failure is a compiler bug problem with all the gcc compilers I could use with the manylinux2014 image. xref pypa/manylinux#494. On the other hand, the failure is in come of the complex trig functions which are blacklisted with glibc<2.18. Originally we blacklisted glbic 2.16, but in numpy/numpy#7518 the blacklisting was extended to 2.18. Perhaps that is too strict? The ppc64le test run hangs in The s390x one runs out of disk space, xref this travis discussion |
Running ppc64le in one of the gcc farm machines, it turns out they define |
Will numpy 1.19 offer arm64 wheels? |
aarch64 and ppc64le are blocked until we can offer post-multibuild2014 wheels, since multibuild2014 does not sufficiently support those architectures. This is the tracking issue for the next generation of wheels. |
cf968da
to
55ffcb8
Compare
5f5fa09
to
cb4280b
Compare
The four new wheels (aarch64 on python 3.6, 3.7, 3.8; pypy on linux64) pass building and testing on travis. numpy/numpy#16224 should add the missing hashes for the azure manylinux1 builds. |
All wheel building passes. |
How do we keep the OpenBLAS version fixed in a release branch? |
The OpenBLAS interaction is entirely defined by |
We normally fix the OpenBLAS version through a release cycle because it makes if easier to track bugs. The numpy and wheels master branches are testing branches, not release branches. It would be good to have a way to pin the OpenBLAS version for releases. |
I propose this workflow:
This means the version of OpenBLAS is always driven by |
Ugh, that's ugly :) I would like to just make a branch in numpy-wheels and everything is done, just like it was before. The master branch can be updated to use new libraries for testing. One possibility might be to use a submodule for the @tylerjereddy @rgommers Thoughts. |
I note that we already have a Also looks like the daily branch is no longer used, I think we can delete it. |
If the version of |
Yeah, I was thinking about that this week--there used to be an environment variable that I would just change for wheels OpenBLAS version changes. The abstraction of the openblas handling machinery to the main repo has the same effect for SciPy. I suppose Not sure we'd want to add much more complexity to that module though. If one used an environment variable the hash checking would probably need to be turned off or accepted by another mechanism then (since the hashes are hard-coded into the module). |
Lets give it a shot. If nothing else, I'd like to see the files in nightly. Thanks Matti. |
Nightly is a misnomer: the cron job builds weekly |
Add aarch64
, ppc64le, s390x wheels,and wheels for pypy3.6 on linux64, linux32, macOS.In total:
64 more wheels. Another PR will be needed for PyPy wheels on windows (only 32 bits is supported)maybe with a move to azure instead of appveyor.