Fill split view background so avoid window glitch

When scrolling too fast the left scroll view might be a little smaller than the split view's immediate content view (which is a custom NSView) due to syntax highlighter-triggered resizing, resulting a gutter at the bottom of the document. Worked around by painting the split view with editor background (so that the gutter is not visible).
MacDownApp · Aug 20, 2014 · 72fa298 · 72fa298
1 parent 529721e
commit 72fa298
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/MacDown/Code/Document/MPDocument.m b/MacDown/Code/Document/MPDocument.m
@@ -1288,12 +1288,17 @@ - (void)setupEditor
         [self.editor setValue:value forKey:key];
     }
 
+    CGColorRef backgroundCGColor = self.editor.backgroundColor.CGColor;
     NSView *editorChrome = self.editor.enclosingScrollView.superview;
+
     CALayer *layer = [CALayer layer];
-    layer.backgroundColor = self.editor.backgroundColor.CGColor;
-    editorChrome.wantsLayer = YES;
+    layer.backgroundColor = backgroundCGColor;
     editorChrome.layer = layer;
 
+    layer = [CALayer layer];
+    layer.backgroundColor = backgroundCGColor;
+    self.splitView.layer = layer;
+
     [self.highlighter activate];
 }
 

diff --git a/MacDown/Localization/Base.lproj/MPDocument.xib b/MacDown/Localization/Base.lproj/MPDocument.xib
@@ -40,7 +40,7 @@
                                     <scrollView borderType="none" autohidesScrollers="YES" horizontalLineScroll="10" horizontalPageScroll="10" verticalLineScroll="10" verticalPageScroll="10" hasHorizontalScroller="NO" usesPredominantAxisScrolling="NO" translatesAutoresizingMaskIntoConstraints="NO" id="5HT-Up-YAd">
                                         <rect key="frame" x="0.0" y="0.0" width="509" height="578"/>
                                         <autoresizingMask key="autoresizingMask"/>
-                                        <clipView key="contentView" copiesOnScroll="NO" id="5eJ-HC-3WM">
+                                        <clipView key="contentView" drawsBackground="NO" copiesOnScroll="NO" id="5eJ-HC-3WM">
                                             <rect key="frame" x="0.0" y="0.0" width="509" height="578"/>
                                             <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                                             <subviews>