Passing integration parameters between C/Python clients and implementations #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As users can choose which actual solver they want to use, it makes sense to name the implementation in a more generic way.
The callee should be responsible for freeing the memory as it is up to them when the passed configuration options are used.
dmitry-kabanov
force-pushed
the
choose-another-method
branch
from
ae8f58b to
8f4a5c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
set_integratorto theIVPinterface that allows to choose a particular integrator from an IVP implementation and set its parameters.For example,
scipy_odeIVP implementation allows setting multiple integrators (dopri5,vode, etc.) and their respective parameters orsundials_cvodeallows choosing betweenBDFandAdamsmethod to solve stiff/nonstiff problems. Hence, the need for such a method.Parameters are passed with the help of a newly added OIF data type
OIF_CONFIG_DICTalong with a supporing C data structureOIFConfigDictthat contains the data in C and supports serialization/deserialization to pass data between different languages.