Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js dependencies #713

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Update Node.js dependencies #713

merged 3 commits into from
Dec 1, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Nov 24, 2024

The title says it all, we update the Node.js dependencies via yarn.

@Splines Splines added the dependencies Pull requests that update a dependency file label Nov 24, 2024
@Splines Splines self-assigned this Nov 24, 2024
fosterfarrell9
fosterfarrell9 previously approved these changes Nov 25, 2024
Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@2e4f26d). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #713   +/-   ##
======================================
  Coverage       ?   54.30%           
======================================
  Files          ?      170           
  Lines          ?     7348           
  Branches       ?        0           
======================================
  Hits           ?     3990           
  Misses         ?     3358           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM.

@Splines
Copy link
Member Author

Splines commented Dec 1, 2024

We have one cypress test that fails. I've verified locally and it works there, hence it is flaky. I will nevertheless merge this PR now as it doesn't have anything to do with the failing test, then fix the test in another PR.

@Splines Splines merged commit eff6ce7 into dev Dec 1, 2024
3 of 4 checks passed
@Splines Splines deleted the deps/update-nodejs branch December 1, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants